Skip to content

Open Telemetry: Adds Batchsize and Rename Batch Operation name in Operation Trace #4622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 6, 2024
Merged

Open Telemetry: Adds Batchsize and Rename Batch Operation name in Operation Trace #4622

merged 6 commits into from
Aug 6, 2024

Conversation

@sourabh1007
Copy link
Contributor

@sourabh1007 sourabh1007 commented Aug 2, 2024 •
edited
Loading

Description

Cosmetic Changes:
Refer, https://opentelemetry.io/docs/specs/semconv/database/cosmosdb/

  1. db.operation => db.operation.name
  2. db.name => db.namespace
  3. db.cosmosdb.container => db.collection.name

Functional Changes:

  1. Add new Attributes as db.operation.batch.size
  2. Operation name should be prepended with BATCH for homogenous operations, or be just BATCH for heterogenous operations.

Type of change

  • [] New feature (non-breaking change which adds functionality)

Reference: #4553

@sourabh1007 sourabh1007 mentioned this pull request Aug 2, 2024
Open
@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/batchsizeinotel branch from 3ed23f5 to c2b9be8 Compare August 2, 2024 10:06
@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/batchsizeinotel branch from c2b9be8 to d656ee0 Compare August 2, 2024 10:35
@kirankumarkolli
Copy link
Member

kirankumarkolli commented Aug 2, 2024

(will be available in bulk and batch operation
Bulk programmatically is internal implementation details should not be part of trace context

@sourabh1007 sourabh1007 marked this pull request as draft August 4, 2024 02:08
@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/batchsizeinotel branch from 38e2a7d to 80340c6 Compare August 4, 2024 02:12
@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/batchsizeinotel branch 4 times, most recently from 040c2f1 to 0093762 Compare August 5, 2024 11:15
@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/batchsizeinotel branch from 0093762 to 1bdad8b Compare August 5, 2024 11:46
@sourabh1007 sourabh1007 marked this pull request as ready for review August 5, 2024 11:52
kirankumarkolli
kirankumarkolli reviewed Aug 6, 2024
View reviewed changes
@sourabh1007 sourabh1007 added the auto-merge Enables automation to merge PRs label Aug 6, 2024
@sourabh1007 sourabh1007 self-assigned this Aug 6, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) August 6, 2024 09:53
FabianMeiswinkel
FabianMeiswinkel approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 9deb6e5 into master Aug 6, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/sourabhjain/batchsizeinotel branch August 6, 2024 10:12
@piotr-rojek piotr-rojek mentioned this pull request Oct 4, 2024
Closed
@philipthomas-MSFT philipthomas-MSFT mentioned this pull request Oct 8, 2024
Closed
This was referenced Jul 28, 2025
Closed
Closed
@dependabot dependabot bot mentioned this pull request Aug 4, 2025
Open
@dependabot dependabot bot mentioned this pull request Sep 22, 2025
Closed
This was referenced Oct 6, 2025
Open
Merged
@dependabot dependabot bot mentioned this pull request Nov 9, 2025
Closed
@dependabot dependabot bot mentioned this pull request Nov 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirankumarkolli kirankumarkolli kirankumarkolli approved these changes

@FabianMeiswinkel FabianMeiswinkel FabianMeiswinkel approved these changes

@ealsur ealsur Awaiting requested review from ealsur

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

@sboshra sboshra Awaiting requested review from sboshra sboshra is a code owner

@khdang khdang Awaiting requested review from khdang khdang is a code owner

@adityasa adityasa Awaiting requested review from adityasa adityasa is a code owner

@neildsh neildsh Awaiting requested review from neildsh neildsh is a code owner

Assignees

@sourabh1007 sourabh1007

Labels

auto-merge Enables automation to merge PRs

Projects

Azure Cosmos SDKs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sourabh1007 @kirankumarkolli @FabianMeiswinkel